Bump ws from 6.2.2 to 6.2.3 in /chromium-src/src/ui/file_manager/image_loader/piex #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [ws](https://github.com/websockets/ws) from 6.2.2 to 6.2.3. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@6.2.2...6.2.3) --- updated-dependencies: - dependency-name: ws dependency-version: 6.2.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
levidehaan
pushed a commit
that referenced
this pull request
Nov 5, 2025
Found and fixed 3 critical bugs during manual code review: Bug #1: Incorrect structured binding in GetDetectedStreams() - GetAllStreams() returns vector<StreamDefinition>, not a map - Changed: for (const auto& [stream_id, stream_def] : all_streams) - To: for (const auto& stream_def : all_streams) Bug #2: Type mismatch in SetStreamActive() - SetStreamActive() returns void, not bool - Cannot assign void return to success variable - Fixed by calling method then setting success = true Bug #3: base::Value not serialized to JSON string - event.data is base::Value but mojom expects string - Added base::JSONWriter::Write() to serialize to JSON - Added missing include: base/json/json_writer.h These were genuine compilation errors that would have prevented the code from building. Manual review caught what automated tools missed. All fixes are minimal and preserve the intended functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps ws from 6.2.2 to 6.2.3.
Release notes
Sourced from ws's releases.
Commits
d87f3b6[dist] 6.2.3eeb76d3[security] Fix crash when the Upgrade header cannot be read (#2231)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.