Skip to content

Conversation

@TomWambsgans
Copy link
Contributor

Goal: make this work.

Copy link
Contributor

@b-wagn b-wagn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that you need to make things public. But the intention of making only certain parts public was to prevent misuse of the library. For users (except the aggregation circuit), signatures and keys should be abstract objects that can only be used as inputs to the functions provided by this library. Users should never look into the internals of these objects. Any idea how to get both? I.e., the same level of protection + make it work for the aggregation? If not, it is ok to merge your PR.

@tcoratger
Copy link
Contributor

Yes I agree with the comment, now if things are public, it's very tempting to access and modify them in the wrong way for the user when he shouldn't.

If this is just to be able to access them and not to modify them (which I think I understand), then you can just have some small functions with the same name as the given field and which return a reference to the said field, that is a common practice to avoid having public visibility for the fields directly.

…ompletely in GeneralizedXMSSSignature / GeneralizedXMSSPublicKey
@TomWambsgans
Copy link
Contributor Author

TomWambsgans commented Dec 12, 2025

Agree with both of you, suggested changes implemented. Is it an issue to make the symmetric module public ?

Copy link
Contributor

@tcoratger tcoratger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@b-wagn b-wagn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can be merged from my perspective :)

@b-wagn b-wagn merged commit 14e277b into main Dec 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants