Timezone-aware datetime Object Support #325
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ability to use datetime objects that are timezone aware for tim…
simo5
requested changes
Jun 27, 2023
Member
simo5
left a comment
simo5
left a comment
There was a problem hiding this comment.
Nits,
also please cleanup the commits, needs sign-off line.
Also please squash into a single comment w/o merge stuff and provide a commit message.
| # Check for datetime objects | ||
| if 'exp' in claims and isinstance(claims['exp'], datetime): | ||
| # Check if timezone aware | ||
| claims['exp'] = self._check_and_convert_dt(claims['exp'], 'exp') |
Member
There was a problem hiding this comment.
I do not think we should modify the array being passed in.
We should instead make a copy in self.claims and modify them there
| return dt_timestamp | ||
| else: | ||
| raise ValueError( | ||
| f"'{claim_prop}' datetime object must be timezone aware" |
Member
There was a problem hiding this comment.
Why does it need to be timezone-aware? Can't we just assume UTC if no timezone is set?
Member
|
Please add a test that verifies this si working properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for datetime objects that are timezone-aware to be used for time-based claims: 'exp' and 'nbf' when making a JWT object, converting them to integer unix timestamps.