Feature/coverage calculation #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owal7428
force-pushed
the
feature/coverage-calculation
branch
from
61811e2 to
5c619f6
Compare
thibaudteil
approved these changes
Nov 1, 2025
Collaborator
thibaudteil
left a comment
thibaudteil
left a comment
There was a problem hiding this comment.
Looks good, is there a way to add a test for this at the moment? Otherwise we can add a RPC test in python
owal7428
force-pushed
the
feature/coverage-calculation
branch
from
5c619f6 to
7e740f6
Compare
owal7428
force-pushed
the
feature/coverage-calculation
branch
from
7e740f6 to
8c6ae23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds coverage calculation using full frame as the bounding box and updates diagnostic protobuf to include the percentage of pixels above fixed threshold.Verification
Values were verified manually using already existing tests. A dedicated test script can't be created until the diagnostics loop is closed and the python interface can be updated.Documentation
NoneFuture work
Closing the diagnostics loop.