Feature/add deimos shape and albedo #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owal7428
force-pushed
the
feature/add_deimos_shape_and_albedo
branch
from
90a0f11 to
c62b100
Compare
owal7428
force-pushed
the
feature/add_deimos_shape_and_albedo
branch
from
c62b100 to
e887ecf
Compare
thibaudteil
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Deimos shape model and albedo map as well as fixes an error in the lommel-seeliger based Regolith BRDF. Also, the CielimMessage protobuf changed to move geometric albedo to shape model parameter.Verification
Changes were validated against real images, the SPICE data of which was used to generate the simulated images in Cielim. Background noise was added afterwards to get a better shape and albedo comparison.Documentation
NoneFuture work
Improvements to albedo map used for Deimos.