Skip to content

Conversation

@lasley
Copy link
Owner

@lasley lasley commented Jan 17, 2018

  • Switch to React
  • Move away from CoffeeScript
  • Refactor (allthethings)

@lasley lasley force-pushed the release/react branch 18 times, most recently from 6ab62f3 to 487fa51 Compare January 18, 2018 01:34
* Switch to React
* Move away from CoffeeScript
* Refactor (allthethings)
@lasley lasley force-pushed the release/react branch 10 times, most recently from 825262e to ba1dd3f Compare January 18, 2018 20:38
@lasley lasley force-pushed the release/react branch 26 times, most recently from 63266f3 to 7715de1 Compare January 23, 2018 00:59
@TonyBrobston
Copy link

TonyBrobston commented Aug 17, 2018

@lasley Great work on this repo!

Just wanted to give you a heads up that I will be playing around with your repo over the next couple weeks. In the last 3-4 months I've gotten into some JavaScript development; specifically React and Node.

I've also been messing around with MakeMKV for a little over a year and up until recently had an automated process setup using this repo: https://github.com/Robpol86/makemkv. It appears that makemkv has gone missing from fedora-multimedia, so this has spurred me to look for other options. One way to solve this issue may very well be to convert Robpol86's docker container to debian and install makemkvcon the same way you do in your makemkvcon docker container.

However Robpol86's repo does not have a way to specifically select which tracks to rip, which I see you solved through some work with sockets; which is awesome. I've been looking for something like this for almost a year. Some blurays have the same track 30+ times and they're the exact same size, which ends up being 20-30 gbs for each. Ropbol86's repo has a check which calculates how much space the rip will consume and then looks at the destination drive to determine if there's enough free space. If there is not enough free space the process is ended. This defeats the purpose of automation because I then have to manually rip it using the default MakeMKV GUI. ☠️

My hope is to help shake out any issues with your release/react branch and see about getting it merged. I'm not familiar with coffeescript, so I'd really like to write in React/Node.

After your branch is merged, I would like to add a feature that helps automate the process.

"As a user of MakeMKV I want to automate the process (open the disk drive, put a disk in, walk away, and come back later to an open disc drive waiting for me to insert another disc and a ripped track in the correct folder to server to Plex), so that I can be most efficient with my time."

I built this branch locally (https://github.com/lasley/docker-node-makemkv/tree/release/react) and am having a few problems that I plan to debug soon.

If you're interested in collaborating, lmk.

@lasley
Copy link
Owner Author

lasley commented Sep 18, 2018

@TonyBrobston - sorry I missed this, been busy with a new job.

Regarding automation - I've been trying to crack this nut for a long long long time, assuming you mean automation of the tracks to rip. There's a bunch of challenges here that I'll lay out in another comment shortly once I have a bit more time. I'll be looking at your PR tomorrow & will find my automation notes to followup here soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants