chore(deps): bump openai from 1.102.0 to 2.4.0 #1406
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [openai](https://github.com/openai/openai-python) from 1.102.0 to 2.4.0. - [Release notes](https://github.com/openai/openai-python/releases) - [Changelog](https://github.com/openai/openai-python/blob/main/CHANGELOG.md) - [Commits](openai/openai-python@v1.102.0...v2.4.0) --- updated-dependencies: - dependency-name: openai dependency-version: 2.4.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
1060
to
1076
|
|
||
| [[package]] | ||
| name = "openai" | ||
| version = "1.102.0" | ||
| version = "2.4.0" | ||
| description = "The official Python library for the openai API" | ||
| optional = false | ||
| python-versions = ">=3.8" | ||
| groups = ["main", "dev"] | ||
| files = [ | ||
| {file = "openai-1.102.0-py3-none-any.whl", hash = "sha256:d751a7e95e222b5325306362ad02a7aa96e1fab3ed05b5888ce1c7ca63451345"}, | ||
| {file = "openai-1.102.0.tar.gz", hash = "sha256:2e0153bcd64a6523071e90211cbfca1f2bbc5ceedd0993ba932a5869f93b7fc9"}, | ||
| {file = "openai-2.4.0-py3-none-any.whl", hash = "sha256:5099f4fbfa80e7e5785ba52402c580eadba21e6172c85df05455676605ad150f"}, | ||
| {file = "openai-2.4.0.tar.gz", hash = "sha256:97860859172b637ffb308433c207a371d4683586ed2b24b360cb4c08cf377d01"}, | ||
| ] | ||
| markers = {main = "extra == \"openai\""} | ||
|
|
||
| [package.dependencies] | ||
| anyio = ">=3.5.0,<5" | ||
| distro = ">=1.7.0,<2" |
Contributor
There was a problem hiding this comment.
logic: Version checking logic in langfuse/openai.py:960-963 uses max_version="1.92.0" to exclude certain method wrappers (beta chat completions parse methods). With OpenAI 2.x, the condition Version(openai.__version__) >= Version("1.92.0") will be true (2.4.0 >= 1.92.0), causing these methods to be skipped during registration, but they should likely still be wrapped for v2.x. The max_version constraint was intended to stop at 1.92.0 when the parse method moved from beta to stable, but the logic doesn't account for major version bumps.
Check if the openai.resources.beta.chat.completions module path still exists in OpenAI 2.x and whether the version filtering logic needs updating to handle 2.x properly.
Prompt To Fix With AI
This is a comment left during a code review.
Path: poetry.lock
Line: 1060:1076
Comment:
**logic:** Version checking logic in `langfuse/openai.py:960-963` uses `max_version="1.92.0"` to exclude certain method wrappers (beta chat completions parse methods). With OpenAI 2.x, the condition `Version(openai.__version__) >= Version("1.92.0")` will be true (2.4.0 >= 1.92.0), causing these methods to be skipped during registration, but they should likely still be wrapped for v2.x. The `max_version` constraint was intended to stop at 1.92.0 when the parse method moved from beta to stable, but the logic doesn't account for major version bumps.
Check if the `openai.resources.beta.chat.completions` module path still exists in OpenAI 2.x and whether the version filtering logic needs updating to handle 2.x properly.
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Author
|
Superseded by #1410. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps openai from 1.102.0 to 2.4.0.
Release notes
Sourced from openai's releases.
... (truncated)
Changelog
Sourced from openai's changelog.
... (truncated)
Commits
ebf3221release: 2.4.0e043d7bchore: fix dangling comment25cbb74feat(api): Add support for gpt-4o-transcribe-diarize on audio/transcriptions ...8cdfd06codegen metadatad5c6443codegen metadatab20a9e7chore(internal): detect missing future annotations with ruffe5f93f5release: 2.3.00448788feat(api): comparison filter in/not in85a91adchore(package): bump jiter to >=0.10.0 to support Python 3.14 (#2618)d69edebrelease: 2.2.0You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Disclaimer: Experimental PR review
Greptile Overview
Updated On: 2025-10-17 05:14:19 UTC
Summary
This PR bumps the OpenAI SDK from 1.102.0 to 2.4.0, a major version upgrade. Key changes:
Dependencies Updated:
openai: 1.102.0 → 2.4.0 (major version bump)langchain-openai: 0.3.32 → 0.3.35 (compatible with OpenAI 2.x, constraint updated to>=1.104.2,<3.0.0)langchain-core: 0.3.75 → 0.3.79jiterconstraint: >=0.4.0 → >=0.10.0 (for Python 3.14 support)OpenAI 2.0 Breaking Changes:
According to the OpenAI changelog, v2.0.0 introduced a breaking change where
ResponseFunctionToolCallOutputItem.outputandResponseCustomToolCallOutput.outputnow returnstring | Array<ResponseInputText | ResponseInputImage | ResponseInputFile>instead of juststring.Potential Issue Found:
The version checking logic in
langfuse/openai.pyusesmax_version="1.92.0"constraints to control when certain method wrappers are registered. This logic doesn't properly handle major version upgrades - with OpenAI 2.4.0, the condition>= Version("1.92.0")evaluates to true, potentially skipping method registrations that should still apply to v2.x.Confidence Score: 2/5
>= Version("1.92.0")will incorrectly evaluate to true for v2.4.0, potentially skipping method wrapper registrations. This could break tracing for beta chat completion parse methods. The OpenAI v2.0 breaking change to output types may also affect response parsing. Tests should be run to verify compatibility.Important Files Changed
File Analysis
Sequence Diagram
sequenceDiagram participant D as Dependabot participant L as poetry.lock participant O as OpenAI SDK participant LF as langfuse/openai.py participant R as register_tracing() D->>L: Update openai 1.102.0 → 2.4.0 L->>L: Update langchain-openai 0.3.32 → 0.3.35 L->>L: Update jiter constraint >=0.4.0 → >=0.10.0 Note over LF,R: On Import Time LF->>R: Call register_tracing() R->>O: Check Version(openai.__version__) O-->>R: Returns "2.4.0" R->>R: For each OpenAiDefinition with max_version Note over R: Check: Version("2.4.0") >= Version("1.92.0") R->>R: Evaluates to TRUE R->>R: SKIP wrapping beta completions.parse Note over R: ⚠️ Potential Issue:<br/>Beta parse methods may not be wrapped<br/>if they still exist in OpenAI 2.x