-
Notifications
You must be signed in to change notification settings - Fork 107
Feature: Add Document Retrieval with Metadata Filtering #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cedrickrusche
wants to merge
5
commits into
langchain-ai:main
Choose a base branch
from
cedrickrusche:feature/search_by_metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature: Add Document Retrieval with Metadata Filtering #231
cedrickrusche
wants to merge
5
commits into
langchain-ai:main
from
cedrickrusche:feature/search_by_metadata
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@cedrickrusche Thank you for opening this PR! I've left a couple of comments |
Author
|
@dishaprakash Thank you for commenting but I can not see the comments |
Collaborator
|
@cedrickrusche sorry about the confusion, is it visible now? |
Author
|
Thank you for the comments. I published the changes @dishaprakash |
Author
|
@dishaprakash should we close that feature request in favour of #264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This pull request introduces the methods get and aget like in ChromaDB to retrieve data by metadata.
🔧 Changes
agetmethod to asynchronously retrieve documents based on optional filters and parameters.getmethod for synchronous document retrieval, leveraging the asynchronousagetmethod.__query_collection_with_filtermethod to support filtering conditions in the SQL WHERE clause without similarity function📈 Impact
These changes let us retrieve the current content to get insights about the data in the database e.g. to find outdated content.