-
Notifications
You must be signed in to change notification settings - Fork 254
crc: basic CMake support #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the pull request. Can you explain to me what these more than 1300 undocumented lines add to the functionality of the CRC calculations? |
|
Code of the project ( sources and headers) was untouched. So it doesn't affect functionality. |
|
So it doesn't add functionality to the CRC functionality, only functionality for project management. Without documentation, this PR will not be merged. |
|
cmake lists has inline comments which describes sections and purpose of each block |
|
It should basically cover the following points
|
|
As an addition: please also look at the INSTALL file in https://github.com/lammertb/libcrc/blob/master/INSTALL which details the specific reasons why the old-fashioned make tool was used in the package, rather than cmake. |
|
supports CMake
build, install, test routines available
generate cmake configuration for
find_package()generate pkg_config instructions
supports include_what_you_use, clang-tidy, unit testing, generation of examples, code coverage report