Fixes asset version name formatting in scan result links #1531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rafi <refaei.shikho@hotmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the formatting of asset version names in scan result URLs by applying slug transformation to ensure URL-safe format. Asset version names that contain spaces, special characters, or other non-URL-safe characters are now properly converted to slugs before being used in URLs.
- Adds
github.com/gosimple/slugpackage import for URL-safe string transformation - Applies
slug.Make()transformation consistently to all asset version names used in URL generation - Ensures generated links work correctly regardless of the characters in asset version names
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seb-kw
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.