Adds should-deploy input for sign and attest and adds propagation in full #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…full Signed-off-by: Sebastian Kawelke <sebastian.kawelke@l3montree.com>
There was a problem hiding this comment.
Pull request overview
This PR adds conditional execution control to the sign and attest workflows by introducing a should-deploy boolean input parameter. This allows callers to optionally skip these jobs while maintaining backward compatibility with a default value of true.
Key Changes:
- Adds
should-deployinput parameter to both sign.yml and attest.yml workflows with a default value oftrue - Implements conditional execution using
if: inputs.should-deployin both workflows - Propagates the
should-deployinput from full.yml to sign.yml and attest.yml workflows
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/sign.yml | Adds should-deploy input and conditional execution to the sign job |
| .github/workflows/attest.yml | Adds should-deploy input and conditional execution to the attest job |
| .github/workflows/full.yml | Propagates the existing should-deploy input to the sign and attest workflow calls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Sebastian Kawelke <sebastian.kawelke@l3montree.com>
timbastin
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.