Skip to content

feat: add a function for getting a consistent connection from the pool #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvc0 merged 1 commit into from
Nov 6, 2025
Merged

feat: add a function for getting a consistent connection from the pool #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions protosocket-rpc/src/client/connection_pool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,16 @@ impl<Connector: ClientConnector> ConnectionPool<Connector> {
}
}

/// Get a consistent connection from the pool for a given key.
pub async fn get_connection_for_key(
&self,
key: usize,
) -> crate::Result<RpcClient<Connector::Request, Connector::Response>> {
let slot = key % self.connections.len();

self.get_connection_by_slot(slot).await
}

/// Get a connection from the pool.
pub async fn get_connection(
&self,
Expand All @@ -72,6 +82,14 @@ impl<Connector: ClientConnector> ConnectionPool<Connector> {
// Safety: This is executed on a thread, in only one place. It cannot be borrowed anywhere else.
let slot = THREAD_LOCAL_SMALL_RANDOM
.with_borrow_mut(|rng| rng.random_range(0..self.connections.len()));

self.get_connection_by_slot(slot).await
}

async fn get_connection_by_slot(
&self,
slot: usize,
) -> crate::Result<RpcClient<Connector::Request, Connector::Response>> {
let connection_state = &self.connections[slot];

// The connection state requires a mutex, so I need to keep await out of the scope to satisfy clippy (and for paranoia).
Expand Down
Loading