allow configuring socket options for raw protosocket servers #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvc0
reviewed
Nov 3, 2025
Comment on lines
63
to
141
| pub async fn new( | ||
| address: std::net::SocketAddr, | ||
| address: SocketAddr, | ||
| runtime: tokio::runtime::Handle, | ||
| connector: Connector, | ||
| config: ProtosocketServerConfig, |
Owner
There was a problem hiding this comment.
If you're going to break source-compatibility, let's make this api private. Add an async fn bind_tcp on ProtosocketServerConfig that delegates to it. This way avoids increasing server initialization complexity.
While we're adding things, let's drop in some documentation on the new structs & functions too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'd be useful to be able to configure the socket with these when writing a server. I also included the three existing configurable fields, since I was adding a config parameter anyway.