Skip to content

✨ (helm/v2-alpha) add tolerations, nodeselector and affinity #5247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
robinlioret wants to merge 1 commit into
base: master
Choose a base branch
from
Open

✨ (helm/v2-alpha) add tolerations, nodeselector and affinity #5247

robinlioret wants to merge 1 commit into from
+338 −33

Conversation

@robinlioret
Copy link

@robinlioret robinlioret commented Nov 25, 2025 •
edited
Loading

Adds nodeSelector, affinity and tolerations to the manager deployment template and values of the helm chart (v2-alpha).

Related issue: #4835

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 25, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: robinlioret / name: Robin LIORET (6152c4d)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 25, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: robinlioret
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 25, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 25, 2025

Hi @robinlioret. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@robinlioret robinlioret force-pushed the feat/helm/v2-alpha/add-tolerations-nodeselector-affinity branch from 57ce1af to 895231c Compare November 25, 2025 08:51
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 25, 2025
@vitorfloriano
Copy link
Contributor

vitorfloriano commented Dec 3, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 3, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 8, 2025
@robinlioret robinlioret force-pushed the feat/helm/v2-alpha/add-tolerations-nodeselector-affinity branch from c3b3709 to 8a3d353 Compare December 8, 2025 14:13
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 8, 2025
@robinlioret robinlioret force-pushed the feat/helm/v2-alpha/add-tolerations-nodeselector-affinity branch 4 times, most recently from c5d400e to 92d1019 Compare December 8, 2025 16:49
@robinlioret robinlioret marked this pull request as draft December 9, 2025 08:08
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2025
@robinlioret robinlioret force-pushed the feat/helm/v2-alpha/add-tolerations-nodeselector-affinity branch 2 times, most recently from b4e70f4 to 401f109 Compare December 9, 2025 10:21
camilamacedo86
camilamacedo86 reviewed Dec 9, 2025
View reviewed changes
docs/book/src/cronjob-tutorial/testdata/project/config/manager/manager.yaml Outdated
# tolerations:
# - key: "key1"
# operator: "Exists"
# effect: "NoSchedule"
Copy link
Member

@camilamacedo86 camilamacedo86 Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do those changes?
Can we live it as before?

Copy link
Member

@camilamacedo86 camilamacedo86 Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need to remove this change here than all seems fine

Copy link
Author

@robinlioret robinlioret Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove it, I added them to be coherent with the other optional fields.

The rest is not fine enough, I still have a weird certificate issue on the e2e helm tests.

Copy link
Author

@robinlioret robinlioret Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2025
@robinlioret robinlioret force-pushed the feat/helm/v2-alpha/add-tolerations-nodeselector-affinity branch from 401f109 to ae78ce5 Compare December 9, 2025 13:12
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2025
@robinlioret robinlioret force-pushed the feat/helm/v2-alpha/add-tolerations-nodeselector-affinity branch from ae78ce5 to 1457d0a Compare December 9, 2025 13:36
@robinlioret robinlioret marked this pull request as ready for review December 9, 2025 13:36
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 9, 2025

@robinlioret: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@robinlioret
Copy link
Author

robinlioret commented Dec 9, 2025

The PR looks ready to be merged.

@robinlioret robinlioret force-pushed the feat/helm/v2-alpha/add-tolerations-nodeselector-affinity branch from 1457d0a to 6152c4d Compare December 9, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

@vitorfloriano vitorfloriano Awaiting requested review from vitorfloriano

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robinlioret @k8s-ci-robot @vitorfloriano @camilamacedo86