🐛 (helm/v2alpha): imagePullSecrets parsing in helm v2-alpha plugin

[zarcen]

The change is to bridge the gap of helm/v2alpha when using images in the private registry.
If users have private image and set imagePullSecrets in the original kustomize, it is not parsed and templated accordingly to helm.

This update allows manager Helm chart to take imagePullSecrets into account and generate the template for it.

Tests:

• I have read and followed CONTRIBUTING.md

1. Unit tests

go test ./pkg/plugins/optional/helm/v2alpha/scaffolds/internal/kustomize
ok  	sigs.k8s.io/kubebuilder/v4/pkg/plugins/optional/helm/v2alpha/scaffolds/internal/kustomize	0.256s
go test ./pkg/plugins/optional/helm/v2alpha/scaffolds/internal/templates
ok  	sigs.k8s.io/kubebuilder/v4/pkg/plugins/optional/helm/v2alpha/scaffolds/internal/templates	0.218s

2. Testdata
   Rather than changing the test/testdata/generate.sh, just keep it as most users may not need imagePullSecrets.
   For users who add imagePullSecrets in their kustomization under config/manager/manager.yaml, this will work nicely.

  spec:
    template:
      spec:
+       imagePullSecrets:
+         - name: ghcr-creds
        containers:
        - command:
          - /manager

This is validated with make generate-charts by applying a local change of testdata/project-v4-with-plugins/config/manager/manager.yaml

The resulting helm template of manager-deployment looks like:

+           {{- if .Values.manager.imagePullSecrets }}
+           imagePullSecrets:
+             {{- toYaml .Values.manager.imagePullSecrets | nindent 14 }}
+           {{- end }}
            securityContext:
              {{- if .Values.manager.podSecurityContext }}
              {{- toYaml .Values.manager.podSecurityContext | nindent 14 }}
              {{- else }}
              {}
              {{- end }}

Closes #5241

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: zarcen / name: Wei-Chen Chen (f6d1a11)

[k8s-ci-robot]

Welcome @zarcen!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @zarcen. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[vitorfloriano]

/ok-to-test

[camilamacedo86]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, zarcen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

@zarcen

Can you please solve the conflict for we get this one merge?

[zarcen]

@zarcen

Can you please solve the conflict for we get this one merge?

Thanks for the review. I have rabased it and kept only one commit.

[zarcen]

I noticed some new version of go linter is enforced. I rebase again to make sure all linters are compliant:

make lint
0 issues.

[k8s-ci-robot]

@zarcen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubebuilder-e2e-k8s-1-33-0	f6d1a11	link	true	/test pull-kubebuilder-e2e-k8s-1-33-0

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.