-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Improve topology diff #13166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Improve topology diff #13166
Conversation
internal/controllers/topology/cluster/structuredmerge/dryrun.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/structuredmerge/dryrun.go
Outdated
Show resolved
Hide resolved
e62204a to
7de0817
Compare
|
/lgtm Thx, very nice improvement! |
|
LGTM label has been added. DetailsGit tree hash: 53e70bfed312b4f877220427373032d6d7e59863 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.12 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sbueringer: new pull request created: #13173 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This PR improves logs for when the topology controller detects a diff
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area clusterclass