🐛 fix: bumps golangci-lint to work with go 1.24+

[faiq]

What type of PR is this?
/kind bug

What this PR does / why we need it:

bumps golangci lint to work with go 1.24+

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• includes emoji in title
• adds unit tests
• adds or updates e2e tests

Release note:

NONE

[dlipovetsky]

/approve
/lgtm

Thank you!

Fixes the problem described in #5792 (comment)

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: dc91c08ef862a03f29d8982b90296bfbac48c09d

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlipovetsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dlipovetsky]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[faiq]

/test pull-cluster-api-provider-aws-e2e-blocking

[dlipovetsky]

cd hack/tools; /home/runner/work/cluster-api-provider-aws/cluster-api-provider-aws/hack/tools/bin/golangci-lint-v2.5.0 custom --verbose
level=info msg="Cloning golangci-lint repository"
level=info msg="error: invalid key:  advice.detachedHead\nfatal: unable to write parameters to config file\n"
Error: build process: clone golangci-lint: git clone --branch v2.5.0 --single-branch --depth 1 -c advice.detachedHead=false -q https://github.com/golangci/golangci-lint.git: exit status 128
The command is terminated due to an error: build process: clone golangci-lint: git clone --branch v2.5.0 --single-branch --depth 1 -c advice.detachedHead=false -q https://github.com/golangci/golangci-lint.git: exit status 128

We use golangci-lint to build the Kubernetes API Linter (KAL), and golangci-lint calls git clone with some flags. But git v2.52.0 breaks flag parsing. What worked previously no longer works. Unfortunately, we have no control over the way golangci-lint calls git.

Here are some issues reported for other projects that call git with flags:

• [Bug?]: Git 2.52.0 breaks git protocol yarnpkg/berry#6982
• Permissions issue on runners v2.330.0 actions/runner#4131 (comment)

Looks like golangci-lint fixed this in golangci/golangci-lint#6205, and released the fix in https://github.com/golangci/golangci-lint/releases/tag/v2.7.0

@faiq Please try the v2.7.0 release in this PR 🙏

[chrischdi]

Ack, golangci-lint v2.7.0 solves this issue.

We also tackled it in CAPI:

• Bumped main to CAPI v2.7.0: 🌱 Bump golangci-lint v2.7.0 cluster-api#13108
• Started using golangci-lint v2.7.0 to build KAL for older release branches: [release-1.11] 🌱 Makefile: ensure KAL is compiled using golangci-lint v2.7.0 cluster-api#13107

[damdo]

I'd say let's go with the same approach that core CAPI went with :)

[faiq]

/retest

[faiq]

We should remove this ignore and address the actual method change to the new one in a later pr.

[dlipovetsky]

Can you create an issue, if there's not one? 🙏

[faiq]

#5795

[faiq]

Thanks folks for the help! I was going crazy debugging that error :)

[dlipovetsky]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 52d55f8b1461552d7f4d7a065278da958379199f

[faiq]

/test pull-cluster-api-provider-aws-verify

[dlipovetsky]

e2e failed due to

generated files are out of date, run make generate

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.