Skip to content

Conversation

@damdo
Copy link
Member

@damdo damdo commented Dec 1, 2025

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

validate inputData during log postprocessing to avoid panic.
Occurrence https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/periodic-cluster-api-provider-aws-e2e/1995405094014685184#1:build-log.txt%3A1594

[PANICKED] in [It] - /usr/local/go/src/runtime/panic.go:792 @ 12/01/25 08:47:22.599
  << Timeline
push_pin
  [PANICKED] Test Panicked
  In [It] at: /usr/local/go/src/runtime/panic.go:792 @ 12/01/25 08:47:22.599
  runtime error: index out of range [1] with length 1
  Full Stack Trace
    panic({0x48b5c60?, 0xc0019e2000?})
    	/usr/local/go/src/runtime/panic.go:792 +0x132
    sigs.k8s.io/cluster-api-provider-aws/v2/test/e2e/shared.postProcessBase64LogData({0xc003156580, 0x6a}, {0x4d195ef?, 0xc000ab8558?}, {0x4d2319d, 0xf})
    	/home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/shared/common.go:315 +0x3b7
    sigs.k8s.io/cluster-api-provider-aws/v2/test/e2e/shared.DumpMachine({_, _}, _, {{{0xc001fcee90, 0xa}, {0xc00293a840, 0x27}}, {{0xc002b167e0, 0x1f}, {0x0, ...}, ...}, ...}, ...)
    	/home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/shared/common.go:218 +0x5ac
    sigs.k8s.io/cluster-api-provider-aws/v2/test/e2e/shared.DumpMachines({0x5416508, 0xc0013a2370}, 0xc0004a72c0, 0x0?)
    	/home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/shared/common.go:127 +0x119
    sigs.k8s.io/cluster-api-provider-aws/v2/test/e2e/shared.AllNodesBeforeSuite.func2()
    	/home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/shared/suite.go:276 +0x127
    created by sigs.k8s.io/cluster-api-provider-aws/v2/test/e2e/shared.AllNodesBeforeSuite in goroutine 103
    	/home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/shared/suite.go:267 +0x70c

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 1, 2025
@k8s-ci-robot k8s-ci-robot requested a review from AndiDog December 1, 2025 14:05
@k8s-ci-robot k8s-ci-robot requested a review from cnmcavoy December 1, 2025 14:05
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2025
@damdo
Copy link
Member Author

damdo commented Dec 1, 2025

/assign @chrischdi

@damdo damdo changed the title fix: e2e: validate inputData during log postprocessing to avoid panic 🌱 fix: e2e test: validate inputData during log postprocessing to avoid panic Dec 1, 2025
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: f07531e0ec6ba89265a0816dae30f066130ff6cc

@damdo
Copy link
Member Author

damdo commented Dec 2, 2025

/assign @kubernetes-sigs/cluster-api-provider-aws-maintainers

@damdo
Copy link
Member Author

damdo commented Dec 2, 2025

/assign @nrb @richardcase @AndiDog @dlipovetsky

Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2025
@damdo
Copy link
Member Author

damdo commented Dec 9, 2025

/test pull-cluster-api-provider-aws-test

@k8s-ci-robot
Copy link
Contributor

@damdo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-test 7f4c07d link true /test pull-cluster-api-provider-aws-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@damdo
Copy link
Member Author

damdo commented Dec 9, 2025

/test pull-cluster-api-provider-aws-test

@k8s-ci-robot k8s-ci-robot merged commit 60a1df2 into kubernetes-sigs:main Dec 9, 2025
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants