Skip to content

Fix release failure after maven central plugin migration #4432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yue9944882 wants to merge 3 commits into
base: master
Choose a base branch
from
+46 −3
Open

Fix release failure after maven central plugin migration #4432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0cae8a
adding manual sonatype API call to make artifact visible
yue9944882 Nov 25, 2025
a3bd247
use echo+pipe for encoding bearer token
yue9944882 Nov 25, 2025
91e8f3b
add missing javadoc plugin
yue9944882 Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,10 @@ jobs:
GPG_PASSPHRASE: ${{ secrets.GPG_PASSWORD }}
run: |
# The tests are already executed in the prepare, skipping
./mvnw -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -DlocalCheckout=true -Darguments=-DskipTests org.apache.maven.plugins:maven-release-plugin:perform
./mvnw -s /home/runner/.m2/settings.xml -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -DlocalCheckout=true -Darguments=-DskipTests org.apache.maven.plugins:maven-release-plugin:perform
curl -X POST \
-H "Authorization: Bearer $(echo ${{ secrets.SNAPSHOT_UPLOAD_USER }}:${{ secrets.SNAPSHOT_UPLOAD_PASSWORD }} | base64 -w0)" \
Copy link
Contributor

@brendandburns brendandburns Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to dump our password into the logs for our github actions workflows? Is there another way to do this?

Copy link
Member Author

@yue9944882 yue9944882 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  # The tests are already executed in the prepare, skipping
  ./mvnw -s /home/runner/.m2/settings.xml -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -DlocalCheckout=true -Darguments=-DskipTests org.apache.maven.plugins:maven-release-plugin:perform
  curl -X POST \
    -H "Authorization: *** ***:*** | base64 -w0)" \
    https://ossrh-staging-api.central.sonatype.com/manual/upload/defaultRepository/io.kubernetes -v
  git push https://***@github.com/kubernetes-client/java.git \
    automated-release-25.0.0-legacy:automated-release-25.0.0-legacy
  git push https://***@github.com/kubernetes-client/java.git v25.0.0-legacy

https://github.com/kubernetes-client/java/actions/runs/19683023331/job/56381525646

the workflow auto-redact the secrets in our workflow ^^^

Copy link
Contributor

@brendandburns brendandburns Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really still don't love this, redaction should be a last resort, not an relied upon feature. There must be some way to do this without it being on the command line.

https://ossrh-staging-api.central.sonatype.com/manual/upload/defaultRepository/io.kubernetes -v
git push https://${{ github.token }}@github.com/${{ github.repository }}.git \
automated-release-${{ github.event.inputs.releaseVersion }}:automated-release-${{ github.event.inputs.releaseVersion }}
git push https://${{ github.token }}@github.com/${{ github.repository }}.git v${{ github.event.inputs.releaseVersion }}
Expand Down
4 changes: 4 additions & 0 deletions client-java-contrib/admissionreview/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
</plugin>
</plugins>
</build>
</project>
4 changes: 4 additions & 0 deletions client-java-contrib/cert-manager/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
</plugin>
</plugins>
</build>
</project>
5 changes: 5 additions & 0 deletions client-java-contrib/prometheus-operator/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
</parent>
<modelVersion>4.0.0</modelVersion>

<name>prometheus-operator-models</name>
<artifactId>client-java-prometheus-operator-models</artifactId>
<version>25.0.0-SNAPSHOT</version>
<dependencies>
Expand All @@ -27,6 +28,10 @@
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
</plugin>
</plugins>
</build>
</project>
9 changes: 9 additions & 0 deletions examples/examples-release-latest/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,13 @@

</dependencies>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
</plugin>
</plugins>
</build>

</project>
22 changes: 20 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
<maven-plugin-version>1.0.0</maven-plugin-version>
<exec-maven-plugin.version>1.6.0</exec-maven-plugin.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.javadoc.failOnError>false</maven.javadoc.failOnError>

<javax.annotation.version>1.3.2</javax.annotation.version>
<jakarta.annotation.version>3.0.0</jakarta.annotation.version>
Expand Down Expand Up @@ -359,9 +360,26 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.12.0</version>
<version>3.11.3</version>
<executions>
<execution>
<id>attach-javadocs</id>
<goals>
<goal>jar</goal>
</goals>
</execution>
</executions>
<configuration>
<doclint>none</doclint>
<!-- TODO: workaround until openapi stops generating a dependency on
the un-exported module: com.google.gson.internal.bind.util -->
<legacyMode>true</legacyMode>
<tags>
Copy link
Contributor

@brendandburns brendandburns Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? Is this part of the TODO above also?

<tag>
<name>http.response.details</name>
<placement>a</placement>
<head>Http Response Details:</head>
</tag>
</tags>
</configuration>
</plugin>
<plugin>
Expand Down
Loading