fix: Improve onboarding wizard sudo handling and npm cleanup #236
+24
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starship's install script internally uses sudo to copy the binary to /usr/local/bin. Previously, the sudo keepalive was killed right after explicit sudo commands, causing Starship to prompt for password. Now sudo credentials are kept alive until all commands complete. Generated with [Claude Code](https://claude.com/claude-code)
…ants Fixes ENOTEMPTY error that occurs when a previous npm installation was interrupted, leaving a non-empty directory that npm can't rename. Now removes existing package directories before npm install -g runs. Generated with [Claude Code](https://claude.com/claude-code)
Code ReviewThis PR addresses two important issues:
Strengths
Suggestions
Security
VerdictApprove with minor suggestions. Successfully fixes real bugs. Code is functional and safe. Recommendations (non-blocking): Add unit tests, make sudo detection explicit, reduce duplication |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code