Skip to content

Update to tidy a few Active_Admin_Importable glitches #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
peterwake wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Update to tidy a few Active_Admin_Importable glitches #33

peterwake wants to merge 13 commits into from

Conversation

@peterwake
Copy link

@peterwake peterwake commented Nov 18, 2016

This pull request fixes a few things that lots of people have created forks for.

  • Rollback if the import crashes
  • Fixing Flash message glitch
  • Tell the user if there is an import error
  • Try to detect the correct character encoding (if using Excel CSV this is a common issue)
  • Fix annoying Active Admin message "using action_item without a name is deprecated"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterwake @baptou12 @griswoldbar