Skip to content

Conversation

@Kunal1522
Copy link
Contributor

@Kunal1522 Kunal1522 commented Dec 25, 2025

Fixes #3199

Modified E2E tests to use --json flag and parse output for function address instead of manually choosing ports. This prevents test failures when the chosen port is already in use.

Changes:

  • Added parseRunJSON helper to eliminate code duplication
  • Modified TestCore_Run,TestCore_Invoke,TestMatrix_Run to use JSON output parsing
  • Removed chooseOpenAddress usage in favor of --json flag

Tests now work reliably even when default ports (8080) are busy.

image

Fixes knative#3199

Modified E2E tests to use --json flag and parse output for function
address instead of manually choosing ports. This prevents test failures
when the chosen port is already in use.

Changes:
- Added parseRunJSON helper to eliminate code duplication
- Modified TestCore_Run to use JSON output parsing
- Modified TestCore_Invoke to use JSON output parsing
- Modified TestMatrix_Run to use JSON output parsing
- Removed chooseOpenAddress usage in favor of --json flag

Tests now work reliably even when default ports (8080) are busy.
@knative-prow
Copy link

knative-prow bot commented Dec 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kunal1522
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 25, 2025
@knative-prow
Copy link

knative-prow bot commented Dec 25, 2025

Hi @Kunal1522. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.34%. Comparing base (039b926) to head (50488cb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3320      +/-   ##
==========================================
- Coverage   55.09%   54.34%   -0.76%     
==========================================
  Files         170      170              
  Lines       19850    19850              
==========================================
- Hits        10937    10788     -149     
- Misses       7845     8030     +185     
+ Partials     1068     1032      -36     
Flag Coverage Δ
e2e 39.53% <ø> (-0.07%) ⬇️
e2e go 35.67% <ø> (+0.05%) ⬆️
e2e node 31.30% <ø> (+0.16%) ⬆️
e2e python 31.39% <ø> (-3.97%) ⬇️
e2e quarkus 31.45% <ø> (+0.16%) ⬆️
e2e rust 30.91% <ø> (+0.17%) ⬆️
e2e springboot 30.91% <ø> (+0.14%) ⬆️
e2e typescript 31.41% <ø> (+0.16%) ⬆️
integration 17.49% <ø> (ø)
unit macos-14 44.96% <ø> (ø)
unit macos-latest 44.96% <ø> (ø)
unit ubuntu-24.04-arm 45.07% <ø> (ø)
unit ubuntu-latest 45.86% <ø> (ø)
unit windows-latest 44.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The 10 second timeout was too short for tests that build images
(e.g., springboot with pack builder). This was causing timeouts
in TestMatrix_Run for certain runtime/builder combinations.

Increased to 5 minutes to accommodate image building time.
@Kunal1522 Kunal1522 marked this pull request as draft December 26, 2025 05:55
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 26, 2025
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 26, 2025
@Kunal1522 Kunal1522 marked this pull request as ready for review December 26, 2025 13:38
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E tests - lisen address extraction

1 participant