-
Notifications
You must be signed in to change notification settings - Fork 169
fix: parse JSON output from func run in E2E tests #3320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fixes knative#3199 Modified E2E tests to use --json flag and parse output for function address instead of manually choosing ports. This prevents test failures when the chosen port is already in use. Changes: - Added parseRunJSON helper to eliminate code duplication - Modified TestCore_Run to use JSON output parsing - Modified TestCore_Invoke to use JSON output parsing - Modified TestMatrix_Run to use JSON output parsing - Removed chooseOpenAddress usage in favor of --json flag Tests now work reliably even when default ports (8080) are busy.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kunal1522 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Kunal1522. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3320 +/- ##
==========================================
- Coverage 55.09% 54.34% -0.76%
==========================================
Files 170 170
Lines 19850 19850
==========================================
- Hits 10937 10788 -149
- Misses 7845 8030 +185
+ Partials 1068 1032 -36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The 10 second timeout was too short for tests that build images (e.g., springboot with pack builder). This was causing timeouts in TestMatrix_Run for certain runtime/builder combinations. Increased to 5 minutes to accommodate image building time.
…ction address in E2E tests
Fixes #3199
Modified E2E tests to use --json flag and parse output for function address instead of manually choosing ports. This prevents test failures when the chosen port is already in use.
Changes:
Tests now work reliably even when default ports (8080) are busy.