Skip to content

Conversation

@gauron99
Copy link
Contributor

No description provided.

@knative-prow
Copy link

knative-prow bot commented Nov 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2025
@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

❌ Patch coverage is 56.22490% with 109 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.92%. Comparing base (b215074) to head (ce56c0b).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/deployer/testing/integration_test_helper.go 0.00% 30 Missing ⚠️
pkg/s2i/scaffolder.go 48.57% 13 Missing and 5 partials ⚠️
pkg/oci/scaffolder.go 54.16% 8 Missing and 3 partials ⚠️
pkg/buildpacks/scaffolder.go 65.21% 7 Missing and 1 partial ⚠️
cmd/deploy.go 70.83% 4 Missing and 3 partials ⚠️
pkg/functions/client.go 62.50% 4 Missing and 2 partials ⚠️
pkg/describer/testing/integration_test_helper.go 0.00% 5 Missing ⚠️
pkg/lister/testing/integration_test_helper.go 0.00% 5 Missing ⚠️
pkg/oci/builder.go 82.14% 2 Missing and 3 partials ⚠️
pkg/remover/testing/integration_test_helper.go 0.00% 5 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3237      +/-   ##
==========================================
+ Coverage   53.14%   54.92%   +1.77%     
==========================================
  Files         170      173       +3     
  Lines       19736    19850     +114     
==========================================
+ Hits        10489    10902     +413     
+ Misses       8236     7885     -351     
- Partials     1011     1063      +52     
Flag Coverage Δ
e2e 39.69% <55.06%> (-0.20%) ⬇️
e2e go 35.75% <56.96%> (-0.13%) ⬇️
e2e node 31.42% <28.48%> (+0.06%) ⬆️
e2e python 35.30% <49.36%> (-0.23%) ⬇️
e2e quarkus 31.55% <28.48%> (+0.03%) ⬆️
e2e rust 30.96% <19.62%> (+0.01%) ⬆️
e2e springboot 30.99% <19.62%> (+0.01%) ⬆️
e2e typescript 31.53% <28.48%> (+0.05%) ⬆️
integration 17.52% <6.31%> (?)
unit macos-14 44.67% <43.68%> (-0.08%) ⬇️
unit macos-latest 44.67% <43.68%> (-0.08%) ⬇️
unit ubuntu-24.04-arm 44.79% <42.57%> (-0.11%) ⬇️
unit ubuntu-latest 45.57% <43.68%> (-0.09%) ⬇️
unit windows-latest 44.68% <43.68%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 force-pushed the push-ywknoytomzzx branch 2 times, most recently from 73ce011 to f310b09 Compare November 22, 2025 15:36
@gauron99 gauron99 changed the title duplicated [DNM][WIP] duplicated func-util test Nov 22, 2025
@gauron99 gauron99 force-pushed the push-ywknoytomzzx branch 4 times, most recently from 5295030 to 8161b74 Compare November 24, 2025 07:04
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2025
@gauron99 gauron99 force-pushed the push-ywknoytomzzx branch 2 times, most recently from e6a1586 to cc15a7d Compare November 24, 2025 13:13
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2025
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2025
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2025
@gauron99 gauron99 changed the title [DNM][WIP] duplicated func-util test [DNM][WIP] scaffolding Dec 18, 2025
@gauron99 gauron99 force-pushed the push-ywknoytomzzx branch 9 times, most recently from 265bb7e to ebb848b Compare December 18, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants