Fix #2778 'Track Link' status is lost when re-saving an existing link in the Rich Text Editor #2829
+13
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix link tracking checkbox state synchronization in rich text editor
Description
This PR fixes a bug in the rich text editor where the "Track link?" checkbox would appear checked but fail to actually track links when users saved without manually toggling the checkbox.
Problem
When inserting links in the TinyMCE rich text editor:
@TrackLinksuffix is not appended to the URLRoot Cause: The checkbox HTML element was set to
checked, but the Vue component'sisTrackLinkstate remainedfalse. TheonEditorURLConvertcallback relies onisTrackLinkto append the tracking suffix.Solution
RichtextEditor.vue:
self.isTrackLink = truewhen the checkbox is rendered as checked@TrackLinksuffix → checkbox checked, tracking preserved@TrackLink→ checkbox unchecked, no tracking addedTesting Steps
@TrackLinksuffix is appended to URL@TrackLink) - verify checkbox stays checked and tracking persistsImpact
Current Testing Results
Please let me know if you have any questions. Thanks!