refactor: switch to fork of go-keyring library #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexec
commented
Nov 22, 2025
alexec
commented
- Replace internal keyring wrapper with direct use of github.com/zalando/go-keyring
- Use replace directive to point to github.com/kitproj/go-keyring fork
- Update tests to clear keyring before testing missing token scenarios
- Replace internal keyring wrapper with direct use of github.com/zalando/go-keyring - Use replace directive to point to github.com/kitproj/go-keyring fork - Update tests to clear keyring before testing missing token scenarios
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the token storage mechanism by removing the internal keyring wrapper and using the github.com/zalando/go-keyring library directly, with a replace directive pointing to the github.com/kitproj/go-keyring fork. The changes simplify the codebase by eliminating platform-specific wrapper code while maintaining the same functionality through the upstream library.
Key changes:
- Removed internal
internal/keyringpackage (wrapper, platform-specific implementations, and tests) - Added replace directive to use
github.com/kitproj/go-keyringv0.2.8 fork - Updated tests to clear keyring state before testing missing token scenarios
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Added replace directive to use kitproj fork; updated go-keyring version; removed unused dependencies |
| go.sum | Updated checksums for new fork and removed unused dependency entries |
| main.go | Replaced internal keyring import with direct zalando/go-keyring import |
| main_test.go | Added keyring.Delete call and import to ensure clean test state |
| mcp_test.go | Added keyring.Delete call and import to ensure clean test state |
| internal/keyring/*.go | Removed entire internal keyring wrapper package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.