Add getJenkinsBuild helper and use it for builds #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work around broken base URL by constructing Build.Base and polling it. Replace direct job.GetBuild calls with getJenkinsBuild and add error handling. Add errors and strconv imports.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a workaround for a broken base URL issue in the gojenkins library by adding a new getJenkinsBuild helper function that manually constructs the build URL and polls it directly.
- Adds
getJenkinsBuildhelper function to work around broken base URL in the gojenkins library - Replaces direct
job.GetBuildcalls ingetBuildandgetBuildLogfunctions with the new helper - Cleans up trailing whitespace in duration-related files
Reviewed Changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| main.go | Adds new getJenkinsBuild helper function with manual URL construction and updates getBuild and getBuildLog to use it; adds errors and strconv imports |
| duration.go | Removes trailing whitespace |
| duration_test.go | Removes trailing whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around broken base URL by constructing Build.Base and polling it. Replace direct job.GetBuild calls with getJenkinsBuild and add error handling. Add errors and strconv imports.