Skip to content

feat: first draft #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexec merged 10 commits into from
Oct 30, 2025
Merged

feat: first draft #2

alexec merged 10 commits into from
Oct 30, 2025

Conversation

@alexec
Copy link
Contributor

@alexec alexec commented Oct 30, 2025

No description provided.

@alexec alexec requested a review from Copilot October 30, 2025 22:25

This comment was marked as duplicate.

Sign in to view

@alexec
Copy link
Contributor Author

alexec commented Oct 30, 2025

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot AI mentioned this pull request Oct 30, 2025
Merged
Copy link
Contributor

Copilot AI commented Oct 30, 2025

@alexec I've opened a new pull request, #3, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 3 commits October 30, 2025 22:32
@alexec
fix: apply code review feedback from PR #2
9f1976d 
Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
@alexec
chore: add .gitignore to exclude binary
7c65300 
Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
@alexec
Merge pull request #3 from kitproj/copilot/sub-pr-2
227c1fb 
Apply code review feedback: fix file I/O and parsing bugs
@alexec alexec requested a review from Copilot October 30, 2025 22:40
@alexec
Copy link
Contributor Author

alexec commented Oct 30, 2025

@copilot please add short tests for

  • markdown.go
  • param_map.go
  • string_slice.go

Copilot AI mentioned this pull request Oct 30, 2025
Merged
Copy link
Contributor

Copilot AI commented Oct 30, 2025

@alexec I've opened a new pull request, #4, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI reviewed Oct 30, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 8 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI and others added 4 commits October 30, 2025 22:45
@alexec
test: add tests for markdown.go, param_map.go, and string_slice.go
ad685bb 
Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
@alexec
Merge pull request #4 from kitproj/copilot/sub-pr-2
cc27430 
test: add unit tests for markdown, param_map, and string_slice
@alexec
Update main.go
4f90fae 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@alexec
Update markdown.go
78408cb 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@alexec alexec marked this pull request as ready for review October 30, 2025 22:53
@alexec alexec merged commit e566210 into main Oct 30, 2025
1 check passed
@alexec alexec deleted the draft branch October 30, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexec