-
Notifications
You must be signed in to change notification settings - Fork 1
Remove task frontmatter from output #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
alexec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@please check the ordering of rules and skills. I think skills are printed after rules.
Skills were being printed twice (once in main.go and once in the Prompt). Removed skills from the Prompt so they are only printed once in main.go, maintaining the correct order: skills -> rules -> task. Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
|
@copilot the correct order is rules, skills, task. Keeps the skills in the resume.prompt field. |
Corrected the output order to be rules, then skills, then task. Skills are now part of the Prompt (result.Prompt field) as intended, appearing between rules and task content. Updated documentation to reflect the correct order. Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an issue where task frontmatter was incorrectly being printed in the output. Task frontmatter is now properly used only for filtering and metadata purposes, keeping the generated context focused on actionable content.
Key changes:
- Removed task frontmatter printing logic from both normal and writeRules modes in main.go
- Updated test to verify frontmatter is NOT printed instead of verifying it IS printed
- Updated documentation across README.md and SPECIFICATION.md to reflect correct behavior and ordering (rules → skills → task)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| main.go | Removed YAML encoding and printing of task frontmatter, removed unused yaml import |
| integration_test.go | Updated TestPrintTaskFrontmatter to verify frontmatter is excluded from output |
| examples/.agents | Added new agents directory marker file |
| SPECIFICATION.md | Updated assembly order, output format examples, and frontmatter usage documentation |
| README.md | Updated diagram and Task Frontmatter section to reflect correct behavior |
Comments suppressed due to low confidence (1)
examples/.agents:1
- This file appears to contain only the text 'agents' without any explanation of its purpose. Consider adding a comment or README to explain what this marker file is for and why it exists in the examples directory.
|
@copilot The tests failed when run on GitHub actions. Please rerun the tests and fix the broken integration test. |
Updated the test to identify stdout by filtering out stderr log lines (lines starting with "time=") instead of looking for the frontmatter delimiter "---" which is no longer printed. Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
Head branch was pushed to by a user without write access
Fixed in fcdf06e. The test was looking for the frontmatter delimiter |
Task Complete: Fixed Task Frontmatter Printing Issue
Summary
Successfully fixed the issue where task frontmatter was being incorrectly printed in the output. Task frontmatter is now properly used for filtering and metadata purposes only, without being included in the generated context.
Changes Made
Code Changes
TestPrintTaskFrontmatterto verify frontmatter is NOT printedTestExpanderSecurityIntegrationto work without frontmatter delimiterDocumentation Updates
Verification
Output Order
Correct order (after fix):
Skills are part of the
result.Promptfield and appear between rules and task content as intended.Security Summary
No security vulnerabilities were discovered or introduced by these changes.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.