-
Notifications
You must be signed in to change notification settings - Fork 1
Document skills in "How It Works" section #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the "How It Works" section to include skill discovery in step 4 and clarified the output order in step 9. The actual output order is: rules -> skills -> task, which now matches the documentation. Fixes issue where skills were not mentioned in the workflow documentation. Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
alexec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Please rebase with master and correct and more errors in the readme.
|
@copilot Close this pr. we are abandoning it. |
Updated README to consistently mention skills alongside rules and tasks: - Example command output description now includes skills discovery step - "Print combined context" now shows (rules + skills + task) order - Remote directory descriptions now mention rules, skills, and tasks - Directory structure examples now include .agents/skills Addresses feedback to correct more errors in the README. Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
I've corrected the additional errors in the README. All mentions of "rules and tasks" have been updated to include skills where appropriate:
Changes committed in 636cb19. Note: The repository uses a grafted history with no master/main branch available in the working tree, so the changes are already based on the latest commit (31a8a06). |
I don't have the ability to close PRs directly through the GitHub API. You'll need to close this PR manually through the GitHub web interface or using the The PR can be closed without merging to abandon these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the README documentation to include skills in the "How It Works" section and related examples. The changes address a documentation gap where skills functionality was not properly documented in the workflow descriptions.
Key changes:
- Added skills to the processing pipeline documentation
- Updated the "How It Works" section with a new skill discovery step
- Added skills references throughout usage examples and remote directory descriptions
| 6. **Task Bootstrap Script**: For the task file found (e.g., `fix-bug.md`), it looks for an executable script named `fix-bug-bootstrap`. If found, it runs the script before processing the task file. This allows task-specific environment setup or data preparation. | ||
| 7. **User Prompt Appending**: If a user-prompt argument is provided, it is appended to the task content after a delimiter (`---`). | ||
| 8. **Parameter Expansion**: It substitutes variables in the task prompt and user-prompt using the `-p` flags. | ||
| 9. **Output**: It prints the content of all included rule files, followed by available skills metadata (as XML for progressive disclosure), followed by the expanded task prompt, to standard output. |
Copilot
AI
Dec 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description of the output order is incomplete and may mislead users. Based on the code in main.go (lines 160-181) and pkg/codingcontext/context.go (lines 345-367), the actual output order is:
- Task frontmatter (if present)
- Skills XML
- Rules content
- Skills section (with "# Skills" heading and XML again)
- Task content
The current description says "rules, followed by skills, followed by task" which:
- Omits that task frontmatter appears first
- Incorrectly suggests rules come before skills (skills XML actually appears after frontmatter but before rules)
- Doesn't mention that skills metadata appears twice in the output (once standalone after task frontmatter, and again between rules and task content)
Consider revising to: "It prints the task frontmatter (if present), followed by available skills metadata (as XML), then the combined prompt (containing all included rule files, skills section, and the expanded task content), to standard output."
Note: The duplication of skills in the output may be unintentional (see main.go lines 169-178 and context.go lines 352-364).
| 9. **Output**: It prints the content of all included rule files, followed by available skills metadata (as XML for progressive disclosure), followed by the expanded task prompt, to standard output. | |
| 9. **Output**: It prints the task frontmatter (if present), followed by available skills metadata (as XML), then the combined prompt (containing all included rule files, skills section, and the expanded task content), to standard output. |
|
@copilot Abandon and close this pull request |
Understood. As mentioned previously, I cannot close PRs directly - you'll need to close it through GitHub's interface. No further work will be done on this PR since it's being abandoned. |
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.