Fix parser failure on empty task content #175
Conversation
- Handle empty/whitespace-only task content gracefully in ParseTask - Add file path to "failed to parse task content" error message - Add unit tests for newline-only and whitespace-only inputs - Add integration tests for tasks with empty content Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a parser failure that occurred when task files contained only frontmatter followed by empty or whitespace-only content. The error unexpected token "\n" is now prevented by adding an early check for whitespace-only content before attempting to parse.
Key Changes:
- Added whitespace-only content check in
ParseTask()to return empty task instead of failing - Enhanced error messages to include file paths for easier debugging
- Added comprehensive test coverage for empty content edge cases
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/codingcontext/taskparser/taskparser.go | Added early return for whitespace-only content to prevent parser failure |
| pkg/codingcontext/taskparser/taskparser_test.go | Added table-driven test cases covering empty string, newlines, and whitespace-only scenarios |
| pkg/codingcontext/context.go | Enhanced error message to include file path when task parsing fails |
| integration_test.go | Added end-to-end test verifying empty task files are handled gracefully |
| if output == "" { | ||
| t.Errorf("expected some output, got empty string") |
There was a problem hiding this comment.
The test validation is too weak. It only checks that output is non-empty, but doesn't verify that the task was actually processed correctly. Consider adding a more specific assertion, such as checking for expected content in the output or verifying that the program completed without errors. For consistency with other integration tests in this file, you could check for specific markers or content that should be present in the output.
Task files with only frontmatter and whitespace/newlines caused parser failure with
unexpected token "\n".Changes
Example
Task file that previously failed:
Now parses successfully and returns an empty task.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.