Skip to content

Conversation

@bimal125
Copy link
Contributor

@bimal125 bimal125 commented Feb 3, 2023

Changes

  • Hide grade4 and grade5

Mention related users here if any.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@bimal125 bimal125 requested a review from thenav56 February 3, 2023 06:21
@bimal125 bimal125 closed this Feb 3, 2023
@bimal125 bimal125 deleted the fix/hide-grades branch February 3, 2023 06:34
@bimal125 bimal125 restored the fix/hide-grades branch February 3, 2023 06:36
@bimal125 bimal125 reopened this Feb 3, 2023
Comment on lines +72 to +73
# GRADE_4 = 'grade_4', _('Grade 4')
# GRADE_5 = 'grade_5', _('Grade 5')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm is this willn't break according to existing data?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to @kopitek8 there are no books of grade 4, 5 now in production server, and for this season we don't upload books for grade 4,5

@kopitek8 Can you confirm here too?

Copy link
Member

@thenav56 thenav56 Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bimal125 Can you also do a quick query and confirm this as well?
In both staging & prod

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No books for grade 4 & 5. Confirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants