Fix per-tenant configuration update at runtime #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vnandwana
commented
Jan 9, 2025
vnandwana
commented
- Updated the PluginConfigurationEventHandler to handle eventConfigKeyName as both a raw string and JSON formatted metadata.
- Added a unit test for this functionality.
…yName as both a raw string and JSON formatted metadata. * Added a unit test for this functionality.
vnandwana
changed the title
pierre
approved these changes
Jan 9, 2025
| } | ||
|
|
||
| @Test(groups = "fast") | ||
| void testConfigure_withValidJsonKey() throws Exception { |
Contributor
There was a problem hiding this comment.
Nit: Maybe follow the same naming convention for test name as other tests in this repo for the sake of consistency.
reshmabidikar
approved these changes
Jan 9, 2025
reshmabidikar
approved these changes
Jan 13, 2025
Contributor
reshmabidikar
left a comment
reshmabidikar
left a comment
There was a problem hiding this comment.
Looks good, however looks like there is a ci failure?
Contributor
Author
Any idea why the libaio.so.1 library is suddenly missing? |
Contributor
Author
|
Fix for missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.