New light Docker image for serverless deployment #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
sbrossie
approved these changes
Aug 30, 2019
| @@ -0,0 +1,14 @@ | |||
| org.killbill.security.shiroNbHashIterations=1 | |||
| org.killbill.jaxrs.threads.pool.nb=5 | |||
| org.killbill.payment.plugin.threads.nb=1 | |||
Member
There was a problem hiding this comment.
You are going from one extreme to the next :-)
Member
Author
There was a problem hiding this comment.
Well, for serverless deployments, the payment integration doesn't really work out of the box:
- Ruby plugins are too memory hungry
- OSS Java payment plugins are for gateways which require IP source whitelisting (unpredictable)
It's really a subscription-only profile which should be deployed :-)
pierre
force-pushed
the
master
branch
4 times, most recently
from
1b7d32c to
b6604cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This light image can be deployed in serverless environments (e.g. Google Cloud Run). Among differences with the main image:
killbill.propertiesas Ansible won't work without/dev/shmaccess (Multiprocess issues when running Ansible programically on AWS Lambda ansible/ansible#18469)This also reduces the default Xms value to 1G. I don't think we need that large of a heap nowadays (other defaults should probably be reviewed at some point).