-
-
Notifications
You must be signed in to change notification settings - Fork 10
Killbill admin new UI #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Removed unnecessary commented code and styles from dashboard, reports, and settings views. - Updated HTML structure to enhance readability and maintainability. - Added specific classes to new report and settings pages for better styling control. - Consolidated styles into a more streamlined format, removing redundant CSS. - Ensured consistent use of Bootstrap classes for layout and responsiveness.
sync with master
Sync with master
New UI page design for analytics plugin
- Added redirection to the default report if no report name is provided in the dashboard controller. - Enhanced report selection logic in the dashboard view to select the second report by default when no report name is specified. - Improved layout and styling of the analytics dashboard, including adjustments to form groups and button styles for better user experience.
Refactor dashboard controller and update analytics dashboard UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the analytics UI with significant design improvements and code formatting updates. The changes implement a new visual design system with updated styles, improved layout structure, and better user experience across the analytics dashboard and reports.
- UI/UX redesign with updated styling (Bootstrap 5 migration, custom color schemes, improved spacing)
- JavaScript code formatting standardization (prettier-style formatting)
- Enhanced modal dialogs and form layouts with better visual hierarchy
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| app/views/kanaui/settings/index.html.erb | Redesigned settings page with new layout structure and button components |
| app/views/kanaui/reports/new.html.erb | Updated report creation page with new heading design and SVG icons |
| app/views/kanaui/reports/index.html.erb | Completely restructured reports index with new header, navigation buttons, and styling |
| app/views/kanaui/reports/edit.html.erb | Updated report edit page matching new design system |
| app/views/kanaui/reports/_reports_table.html.erb | Duplicated table implementation with Bootstrap 5 modal updates |
| app/views/kanaui/reports/_form.html.erb | Duplicated form implementation with updated styling and button components |
| app/views/kanaui/dashboard/index.html.erb | Major dashboard redesign with sidebar integration, improved date controls, and advanced controls section |
| app/controllers/kanaui/dashboard_controller.rb | Added default report redirection logic |
| app/assets/stylesheets/kanaui/reports.css | Updated chart title styling with vertical rotation |
| app/assets/stylesheets/kanaui/kanaui.css | Added 700+ lines of comprehensive CSS for all new components |
| app/assets/javascripts/kanaui/reports.dataTables.js | Code formatting improvements (prettier-style) |
| app/assets/javascripts/kanaui/kiddo/*.js | Code formatting improvements across all kiddo chart files |
| app/assets/javascripts/kanaui/kiddo/charts/*.js | Updated chart color schemes and formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Refactor reports UI components and enhance URL validation in report navigation
Update new UI