Skip to content

Conversation

@tungleduyxyz tungleduyxyz force-pushed the kaui_12.17 branch 6 times, most recently from 9504f41 to 7c39b51 Compare December 16, 2025 16:55
@tungleduyxyz tungleduyxyz requested a review from Copilot December 16, 2025 17:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses multiple bug fixes and UI improvements across the Kaui admin interface, focusing on placeholder text corrections, form validation enhancements, and data handling improvements.

  • Fixed inconsistent placeholder text across multiple views to accurately reflect the context (Payments, Invoices, Logs, Account Timelines instead of generic "All Accounts")
  • Added custom JavaScript form validation for catalog creation to handle jQuery autocomplete interference with HTML5 validation
  • Improved error handling and data display for dashboard metrics and invoice filtering

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test/dummy/config/initializers/money.rb Sets default currency to USD for Money gem
app/views/kaui/payments/_multi_functions_bar.html.erb Corrects placeholder from "All Accounts" to "All Payments"
app/views/kaui/invoices/_multi_functions_bar.html.erb Corrects placeholder from "All Accounts" to "All Invoices"
app/views/kaui/components/dashboard/_card.html.erb Adds fallback text "20k+" for nil count values
app/views/kaui/audit_logs/_multi_functions_bar.html.erb Corrects placeholder from "All Accounts" to "All Logs"
app/views/kaui/admin_tenants/new_catalog.html.erb Implements custom form validation with error handling for Product and Plan names
app/views/kaui/admin_allowed_users/index.html.erb Refactors delete button implementation and adds error handling for DataTable initialization
app/views/kaui/accounts/_billing_details.html.erb Removes permission check wrapper around "Next invoice date" field
app/views/kaui/account_timelines/_multi_functions_bar.html.erb Corrects placeholder from "All Accounts" to "All Account Timelines"
app/helpers/kaui/plugin_helper.rb Adds route mapping for 'aviate' plugin
app/controllers/kaui/invoices_controller.rb Implements date range filtering for invoice downloads
app/controllers/kaui/home_controller.rb Removes nil fallback (

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

}
} %>
<%= form_tag kaui_engine.admin_allowed_user_path(u.id), method: :delete, style: 'display: inline;', onsubmit: "return confirm('Are you sure?');" do %>
<%= button_tag type: 'submit', class: 'btn btn-outline-secondary d-inline-flex align-items-center gap-1 kaui-button delete-button custom-hover', style: 'border: none; background: none; padding: 0;' do %>
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline styles override the button's CSS classes, which may cause inconsistent styling. The inline styles 'border: none; background: none; padding: 0;' conflict with the 'btn btn-outline-secondary' classes. Consider moving these styles to a dedicated CSS class or removing conflicting class assignments.

Suggested change
<%= button_tag type: 'submit', class: 'btn btn-outline-secondary d-inline-flex align-items-center gap-1 kaui-button delete-button custom-hover', style: 'border: none; background: none; padding: 0;' do %>
<%= button_tag type: 'submit', class: 'btn btn-outline-secondary d-inline-flex align-items-center gap-1 kaui-button delete-button custom-hover kaui-btn-no-border' do %>

Copilot uses AI. Check for mistakes.
@tungleduyxyz tungleduyxyz merged commit 3dec589 into master Dec 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants