refactor/KD-62: SecurityConfig 프론트엔드 베포 페이지 포함 #313
Conversation
WalkthroughSecurityConfig.java의 CORS 설정에서 allowedOriginPatterns에 "https://aics-client-graduate.vercel.app/"을 추가하여 CORS 허용 출처를 확장했습니다. 다른 동작이나 오류 처리 변경사항은 없습니다. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test Coverage Report
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## develop #313 +/- ##
==========================================
Coverage 86.51% 86.51%
Complexity 67 67
==========================================
Files 24 24
Lines 267 267
Branches 14 14
==========================================
Hits 231 231
Misses 24 24
Partials 12 12 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Fix all issues with AI Agents 🤖
In @aics-common/src/main/java/kgu/developers/common/config/SecurityConfig.java:
- Line 105: Remove the trailing slash from the CORS origin entries in
SecurityConfig so Origin matching succeeds; specifically update the strings
"https://aics-client-graduate.vercel.app/" and the other HTTPS URL on the
adjacent line to remove the trailing "/" (i.e., use
"https://aics-client-graduate.vercel.app" etc.), in the allowed origins list /
CorsConfiguration setup within SecurityConfig.java.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
aics-common/src/main/java/kgu/developers/common/config/SecurityConfig.java
🔇 Additional comments (1)
aics-common/src/main/java/kgu/developers/common/config/SecurityConfig.java (1)
105-105: 새로운 graduate URL의 CORS 설정이 코드에 올바르게 구현되었는지 확인 필요
https://aics-client-graduate.vercel.app/URL이 SecurityConfig.java의 CORS allowedOriginPatterns에 정상적으로 추가되었습니다. 다음을 확인했습니다:
- URL이 기존
aics-client-dev.vercel.app와 동일한 명명 규칙을 따르고 있음- CORS 설정이 올바르게 구현되어 있음 (allowCredentials=true, 메서드 및 헤더 설정 완료)
- 해당 URL은 코드베이스에서 이 위치 외에 다른 곳에서 참조되지 않음
그러나 다음 사항은 코드 검토만으로는 확인할 수 없으므로 확인이 필요합니다:
- 이 URL이 실제로 배포되었고 접근 가능한지 여부
- 팀에서 이 CORS 허용을 공식적으로 승인했는지 여부
| "https://aics-admin.kgudevelopers.monster", | ||
| "https://aics-auth.kgudevelopers.monster", | ||
| "https://aics-client-dev.vercel.app/", | ||
| "https://aics-client-graduate.vercel.app/", |
There was a problem hiding this comment.
CORS 패턴의 후행 슬래시 제거 필요
추가된 URL에 후행 슬래시(/)가 포함되어 있습니다. HTTP Origin 헤더는 일반적으로 후행 슬래시를 포함하지 않고 전송되기 때문에(예: https://aics-client-graduate.vercel.app), 이로 인해 CORS 매칭이 실패할 수 있습니다.
또한 Line 101-103의 다른 HTTPS URL들과의 일관성을 위해서도 후행 슬래시를 제거하는 것이 좋습니다. Line 104도 동일한 문제가 있습니다.
🔎 제안하는 수정사항
"https://aics-client-dev.vercel.app/",
- "https://aics-client-graduate.vercel.app/",
+ "https://aics-client-graduate.vercel.app",
"http://175.45.195.63",Line 104의 후행 슬래시도 함께 제거하는 것을 권장합니다:
- "https://aics-client-dev.vercel.app/",
+ "https://aics-client-dev.vercel.app",
"https://aics-client-graduate.vercel.app",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "https://aics-client-graduate.vercel.app/", | |
| "https://aics-client-graduate.vercel.app", |
🤖 Prompt for AI Agents
In @aics-common/src/main/java/kgu/developers/common/config/SecurityConfig.java
around line 105, Remove the trailing slash from the CORS origin entries in
SecurityConfig so Origin matching succeeds; specifically update the strings
"https://aics-client-graduate.vercel.app/" and the other HTTPS URL on the
adjacent line to remove the trailing "/" (i.e., use
"https://aics-client-graduate.vercel.app" etc.), in the allowed origins list /
CorsConfiguration setup within SecurityConfig.java.
Summary
SecurityConfig에 프론트엔드 졸업 시스템 개발 페이지를 포함시켰습니다.
Tasks