Skip to content

Conversation

@JangYeongHu
Copy link
Contributor

Summary

ADMIN 권한의 계정이 GraduationUser API에 접근 거부되는 오류를 수정하였습니다.

Tasks

  • GraduationUserControllerImpl의 PreAutorize를 제거

@JangYeongHu JangYeongHu self-assigned this Jan 4, 2026
@JangYeongHu JangYeongHu added the 🐞bug Something isn't working label Jan 4, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 4, 2026

Walkthrough

GraduationUserControllerImpl 클래스에서 @PreAuthorize("hasRole('ROLE_USER')") 어노테이션과 관련 import 문을 제거했습니다. 메서드 로직이나 서명은 변경되지 않았으며, 엔드포인트 동작은 기존 매핑을 통해 유지됩니다.

Changes

Cohort / File(s) 변경 사항
보안 어노테이션 제거
aics-api/src/main/java/kgu/developers/api/graduationUser/presentation/GraduationUserControllerImpl.java
클래스 레벨의 @PreAuthorize("hasRole('ROLE_USER')") 어노테이션 삭제 및 PreAuthorize import 제거

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

  • 졸업 api의 접근 권한 수정 #310: GraduationUserControllerImpl에서 @PreAuthorize 기반 접근 제한 제거에 대한 동일한 코드 레벨의 수정사항을 다루고 있어 관련성이 있음

Suggested reviewers

  • dkdltm221
  • LeeHanEum

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 변경 사항의 주요 내용을 명확하게 설명하고 있습니다. GraduationUserControllerImpl에서 PreAuthorize를 제거했다는 핵심 변경 사항을 정확하게 요약하고 있습니다.
Description check ✅ Passed PR 설명이 변경 사항과 관련이 있습니다. ADMIN 권한 계정의 접근 거부 오류 수정과 PreAuthorize 제거라는 구체적인 작업을 설명하고 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 42bedfb and 569fb88.

📒 Files selected for processing (1)
  • aics-api/src/main/java/kgu/developers/api/graduationUser/presentation/GraduationUserControllerImpl.java
💤 Files with no reviewable changes (1)
  • aics-api/src/main/java/kgu/developers/api/graduationUser/presentation/GraduationUserControllerImpl.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Test Coverage Report

Overall Project 80.41% 🍏

There is no coverage information present for the Files changed

@codecov
Copy link

codecov bot commented Jan 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #311   +/-   ##
==========================================
  Coverage      86.51%   86.51%           
  Complexity        67       67           
==========================================
  Files             24       24           
  Lines            267      267           
  Branches          14       14           
==========================================
  Hits             231      231           
  Misses            24       24           
  Partials          12       12           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42bedfb...569fb88. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@dkdltm221 dkdltm221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JangYeongHu JangYeongHu merged commit fe15c70 into develop Jan 5, 2026
5 checks passed
@JangYeongHu JangYeongHu deleted the fix/KD-61 branch January 5, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants