test(web): add baseline tests for .js keyboards 🧪 🎼 #15341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
ermshiperete
force-pushed
the
test/web/jsbaseline
branch
from
295bb5d to
8927ee2
Compare
Test-bot: skip
ermshiperete
force-pushed
the
test/web/jsbaseline
branch
from
8927ee2 to
80c1f88
Compare
ermshiperete
added a commit
that referenced
this pull request
Dec 12, 2025
This change groups similar tests together. Also update `build.sh` to compile .js files. Follow-up-of: #15341 Test-bot: skip
ermshiperete
added a commit
that referenced
this pull request
Dec 12, 2025
This change groups similar tests together. Also update `build.sh` to compile .js files. Follow-up-of: #15341 Test-bot: skip
ermshiperete
added a commit
that referenced
this pull request
Dec 12, 2025
This change groups similar tests together. Also update `build.sh` to compile .js files. Follow-up-of: #15341 Test-bot: skip
ermshiperete
added a commit
that referenced
this pull request
Dec 12, 2025
This change groups similar tests together. Also update `build.sh` to compile .js files. Follow-up-of: #15341 Test-bot: skip
ermshiperete
changed the title
ermshiperete
added a commit
that referenced
this pull request
Dec 15, 2025
This change groups similar tests together. Also update `build.sh` to compile .js files. Follow-up-of: #15341 Test-bot: skip
jahorton
reviewed
Dec 15, 2025
Contributor
jahorton
left a comment
jahorton
left a comment
There was a problem hiding this comment.
I'm curious how some of the "failing" tests are failing here. Some of those listed had other unit tests built to target the same functionality - I specifically recall k_025 being one of them.
There's a strong chance that this linked test (and some following it!) are designed to test the same thing as the fixture mentioned above:
Refer to #2884. It does appear that one directly used k_023's keyboard (see header of web/unit_tests/resources/keyboards/options_with_save.js), though I believe the linked test above aimed to cover k_025's focus.
| 'k_037___options___double_reset.kmn', | ||
| 'k_039___generic_ctrlalt.kmn', | ||
| 'k_049___enter_invalidates_context.kmn', | ||
| 'k_055___deadkey_cancelled_by_arrow.kmn', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'k_055___deadkey_cancelled_by_arrow.kmn', | |
| 'k_055___deadkey_cancelled_by_arrow.kmn', // Keyman Engine for Web does not interpret arrow keys |
Member
There was a problem hiding this comment.
Deadkeys should be cancelled by caret movement. So we need to fix this at some point.
| 'k_049___enter_invalidates_context.kmn', | ||
| 'k_050___nul_and_context.kmn', // js only | ||
| 'k_052___nul_and_index.kmn', // js only | ||
| 'k_055___deadkey_cancelled_by_arrow.kmn', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'k_055___deadkey_cancelled_by_arrow.kmn', | |
| 'k_055___deadkey_cancelled_by_arrow.kmn', // Keyman Engine for Web does not interpret arrow keys |
mcdurdin
approved these changes
Dec 21, 2025
Member
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
If we could rebuild those .js fixtures with debug, then this looks like a good step forward
Member
There was a problem hiding this comment.
I think it would be good for the fixtures to be generated with debug so we get source line numbers and readable code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds baseline tests for .js keyboards. Several of those tests fail and so are skipped for now (#15342).
This test also includes the .js files of the baseline keyboards because they can't easily be generated on non-Windows platforms. This is similar to the .kmx files that are also included in the repo for the same reason.
Test-bot: skip