feat(web): implement subkey menu realignment for even columns (#9768) #15324
+303
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…app#9768) This change addresses a usability issue where subkey popup menus with even-numbered columns (2, 4, 6, 8) create ambiguous default selection. When there's an even number of columns, the centered position falls between two options, making it unclear which character will be selected. The solution shifts the popup menu alignment based on the base key's position on the keyboard: - Keys on the right side: shift menu left by half a key width - Keys on the left side: shift menu right by half a key width This ensures one option always sits unambiguously under the default touch position, following the pattern used by Google's Gboard. Changes: - Added numColumns instance variable to track column count - Modified reposition() to apply shift for even-column layouts - Added comprehensive unit tests for even/odd column scenarios - Existing bounds checking prevents menu overflow Closes keymanapp#9768
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions ERROR: user tests have not yet been defined |
Collaborator
|
This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to resolve #9768
This change addresses a usability issue where subkey popup menus with
even-numbered columns (2, 4, 6, 8) create ambiguous default selection.
When there's an even number of columns, the centered position falls
between two options, making it less predictable which character will be selected.
The solution shifts the popup menu alignment based on the base key's
position on the keyboard:
This ensures one option always sits unambiguously under the default
touch position, following the pattern used by Google's Gboard.
It is noted that the shift may be larger (up to a limit) if the selected key has an unusual width.
Changes:
Closes #9768 (#9768)
User Testing: