refactor(web): renames PendingTokenization as TokenizationPath, adds doc-comments 🚂 #15095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
jahorton
force-pushed
the
refactor/web/transform-tokenization-subset-ids
branch
from
d13ebc8 to
1d113f5
Compare
jahorton
force-pushed
the
refactor/web/rename-and-doc-pending-tokenization
branch
from
8f1e7b1 to
6daa809
Compare
jahorton
force-pushed
the
refactor/web/transform-tokenization-subset-ids
branch
from
1d113f5 to
e97c968
Compare
jahorton
force-pushed
the
refactor/web/rename-and-doc-pending-tokenization
branch
from
6daa809 to
461fa4d
Compare
jahorton
force-pushed
the
refactor/web/transform-tokenization-subset-ids
branch
from
e97c968 to
0792377
Compare
…doc-comments Now that the SearchSpace rework is stabilizing, I've finally landed on a better name for the type. PendingTokenization _directly_ correlates to `SearchPath` entries once processed, so the name `TokenizationPath` will reflect this nicely. New doc-comments are also added documenting the relationship of `TokenizationPath` and `TokenizationSubset` to `SearchPath` and `SearchCluster`. Admittedly, it may be wise to additionally rename `TokenizationSubset` to `TokenizationCluster` (and rename the source file) to further mirror the relationship of these types... but that can always be done in a follow-up. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/rename-and-doc-pending-tokenization
branch
from
461fa4d to
449ebec
Compare
…factor/web/rename-and-doc-pending-tokenization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the SearchSpace rework is stabilizing, I've finally landed on a better name for the type. PendingTokenization directly correlates to
SearchPathentries once processed, so the nameTokenizationPathwill reflect this nicely. New doc-comments are also added documenting the relationship ofTokenizationPathandTokenizationSubsettoSearchPathandSearchCluster.Admittedly, it may be wise to additionally rename
TokenizationSubsettoTokenizationCluster(and rename the source file) to further mirror the relationship of these types... but that can always be done in a follow-up.Build-bot: skip build:web
Test-bot: skip