refactor(web): adds unique identifier to transform-tokenization subsets 🚂 #15094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
jahorton
commented
Nov 4, 2025
Comment on lines
173
to
174
| // check... this. | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Suggested change
| // check... this. |
Oops.
jahorton
force-pushed
the
refactor/web/transform-tokenization-subset-ids
branch
2 times, most recently
from
d13ebc8 to
1d113f5
Compare
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
ca906dd to
316abe3
Compare
jahorton
force-pushed
the
refactor/web/transform-tokenization-subset-ids
branch
from
1d113f5 to
e97c968
Compare
jahorton
changed the base branch from
refactor/web/complex-search-space-reuse
to
refactor/web/relocate-source-range-key
This addition will allow us to clearly and cleanly indicate transforms that are two (or more) halves of the same original whole. It is notably more selective than just the original transition ID and is better suited for indicating split-transform cases. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/transform-tokenization-subset-ids
branch
from
e97c968 to
0792377
Compare
…/rename-inputsource-as-pathinputprops
…efactor/web/transform-tokenization-subset-ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition will allow us to clearly and cleanly indicate transforms that are two (or more) halves of the same original whole. It is notably more selective than just the original transition ID and is better suited for indicating split-transform cases.
Build-bot: skip build:web
Test-bot: skip