Skip to content

Add support for CEL-based mutation rules #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kcp-ci-bot merged 4 commits into from
Dec 9, 2025
Merged

Add support for CEL-based mutation rules #125

kcp-ci-bot merged 4 commits into from
Dec 9, 2025

Conversation

@xrstf
Copy link
Contributor

@xrstf xrstf commented Dec 8, 2025 •
edited
Loading

Summary

This adds CEL-based mutations to the syncagent. CEl is nice because it allows for simply arithmetic and logic operations without the possibility to too much danger.

The implementation is quite simple: You configure a tuple of (path,expression) and then the agent will find the value at the given JSONPath in an object, process it using the CEL expression and then writes the resulting value back into the object. THe selected value and both full objects are available as variables in the expression.

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #73

Release Notes

Add support for CEL-based mutation rules.

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Dec 8, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Dec 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot kcp-ci-bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 8, 2025
@xrstf xrstf changed the title WIP CEl stuff, but need to stop because it seems to be kube 1.33+ only Add support for CEL-based mutation rules Dec 8, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/test all

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 8, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/kind feature

@kcp-ci-bot kcp-ci-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 8, 2025
@xrstf xrstf marked this pull request as ready for review December 8, 2025 14:56
@kcp-ci-bot kcp-ci-bot removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 8, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/retest

@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/test pull-api-syncagent-test-e2e-kcp-0.27
/test pull-api-syncagent-test-e2e-kcp-0.28
/test pull-api-syncagent-test-e2e-kcp-0.29

4 similar comments
@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/test pull-api-syncagent-test-e2e-kcp-0.27
/test pull-api-syncagent-test-e2e-kcp-0.28
/test pull-api-syncagent-test-e2e-kcp-0.29

@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/test pull-api-syncagent-test-e2e-kcp-0.27
/test pull-api-syncagent-test-e2e-kcp-0.28
/test pull-api-syncagent-test-e2e-kcp-0.29

@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/test pull-api-syncagent-test-e2e-kcp-0.27
/test pull-api-syncagent-test-e2e-kcp-0.28
/test pull-api-syncagent-test-e2e-kcp-0.29

@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/test pull-api-syncagent-test-e2e-kcp-0.27
/test pull-api-syncagent-test-e2e-kcp-0.28
/test pull-api-syncagent-test-e2e-kcp-0.29

@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

Okay it feels the tests are indeed much more stable now #jinxedit 🤞

xrstf added 3 commits December 9, 2025 17:05
@xrstf
add support for CEL-based mutation steps in PublishedResources
de80ee2 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
documentation
6c1c20a 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
attempt to reduce flakiness
333b6e4 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
remove accidental debug leftover
361114a 
On-behalf-of: @SAP christoph.mewes@sap.com
ntnn
ntnn approved these changes Dec 9, 2025
View reviewed changes
Copy link
Member

@ntnn ntnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Dec 9, 2025

LGTM label has been added.

DetailsGit tree hash: 2f0ad99862bfe0e28a349c545213d497c21e8f2c

@xrstf
Copy link
Contributor Author

xrstf commented Dec 9, 2025

/approve

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Dec 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ntnn, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2025
@kcp-ci-bot kcp-ci-bot merged commit 2d86372 into main Dec 9, 2025
11 checks passed
@kcp-ci-bot kcp-ci-bot deleted the cel-mutations branch December 9, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntnn ntnn ntnn approved these changes

Assignees

@ntnn ntnn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature: Add CEL-based mutations

4 participants

@xrstf @kcp-ci-bot @ntnn