Skip to content

MCPServer: allow default image injection (npx/uvx) and set Healthy wh… #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhbh merged 2 commits into from
Nov 17, 2025
+6 −1
Merged

MCPServer: allow default image injection (npx/uvx) and set Healthy wh… #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfa3a59
MCPServer: allow default image injection (npx/uvx) and set Healthy wh…
intojhanurag Sep 17, 2025
fba8f91
remove binary file changes
intojhanurag Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added kind
View file
Open in desktop
Binary file not shown.
5 changes: 4 additions & 1 deletion pkg/controller/mcpserver_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,11 @@ func (r *MCPServerReconciler) validateMCPServer(server *kagentdevv1alpha1.MCPSer
}

// Check if required fields are present
// Allow empty image if command is npx or uvx (default images will be injected)
if server.Spec.Deployment.Image == "" {
return fmt.Errorf("deployment.image is required")
if server.Spec.Deployment.Cmd != "npx" && server.Spec.Deployment.Cmd != "uvx" {
return fmt.Errorf("deployment.image is required when command is not 'npx' or 'uvx'")
}
}

// Additional validation could be added here
Expand Down
2 changes: 2 additions & 0 deletions pkg/controller/transportadapter/transportadapter_translator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,11 @@ func (t *transportAdapterTranslator) translateTransportAdapterDeployment(
image := server.Spec.Deployment.Image
if image == "" && server.Spec.Deployment.Cmd == "uvx" {
image = "ghcr.io/astral-sh/uv:debian"
klog.Infof("MCPServer %s: Injected default image for uvx command: %s", server.Name, image)
}
if image == "" && server.Spec.Deployment.Cmd == "npx" {
image = "node:24-alpine3.21"
klog.Infof("MCPServer %s: Injected default image for npx command: %s", server.Name, image)
}
if image == "" {
return nil, fmt.Errorf("image must be specified for MCPServer %s or the command must be 'uvx' or 'npx'", server.Name)
Expand Down
Loading