feat: Adding new role type - mixed #191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes following changes: - Adding new role type: mixed. In case pipline has a mixed source (valid for both agent and aggregator). - New skipPrefix flag on vectorpipelines and clustervectorpipelines. If specified will skip adding a prefix to a pipeline name(namespace + object name). Required when using wildcard in input references from different pipeline. - Applying linter fixes which were missed before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue with wildcard processing in input parameters.
Vector supports wildcard identifiers: https://vector.dev/highlights/2021-01-20-wildcard-identifiers/
This is extremely useful in case you have to deal with multi-tenancy configurations(different projects store observability data in different accounts/resources)
Attaching a diagram with an example use-case:
In order to achieve this, following 2 issues needs to be solved:
I added required changes in my PR.
This PR includes following changes:
In case pipeline has a mixed source (valid for both agent and aggregator).
If specified will skip adding a prefix to a pipeline name(namespace + object name).
Required when using wildcard in input references from different pipeline.