-
Notifications
You must be signed in to change notification settings - Fork 1
Search results page 4.1 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joshngu
wants to merge
15
commits into
master
Choose a base branch
from
SearchResultsPage4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json
# Conflicts: # client/src/Routes.tsx # client/src/pages/HomePage/HomePage.module.css # client/src/pages/HomePage/HomePage.tsx # client/src/pages/TestPage/TestPage.tsx
Bump sharp and related dependencies from 0.34.4 to 0.34.5 in package.json and package-lock.json for improved compatibility and bug fixes.
…ute; fix dev startup without envs\n\n- client: add /search route, create api/search.api.ts, wire TopBar Enter to navigate, fix SongCard props and casing in HomePage, clean Routes unused import, adjust TestPage year display\n- server: implement /api/search route, use config path aliases, safe DB/query helpers, dev-safe Azure/JWT config, resilient DB loading and start\n- build: ensure server and client build cleanly # Conflicts: # client/src/Routes.tsx # client/src/api/search.api.ts # client/src/pages/HomePage/HomePage.tsx # client/src/pages/TestPage/TestPage.tsx # client/src/pages/index.ts # server/src/routes/index.ts # server/src/routes/search.routes.ts
… artist bio and song genre
ed6823f to
28703fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major UI refactor for the music app, adding new layout components for navigation, playback, and search, and updating routing to support a search results page. The changes also include a new API for search functionality, improvements to card and featured section components, and updates to page structure to incorporate the new layout elements.