Fix double URL encoding error when creating a notebook in a folder containing spaces #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

tomasr8 wants to merge 1 commit into jupyter:main from tomasr8:fix-notebook-path

tomasr8 commented Dec 4, 2025

Fixes jupyter/notebook#5841

Steps to reproduce:

Run jupyter nbclassic
Create a new folder with a space in the name
Open the folder
Refresh the page (<body>'s data-notebook-path should now be url-encoded)
Create a new python3 notebook
Get the error from the linked issue

The fix is to use the existing util get_body_data to first decode the notebook path since Contents.prototype.api_url will encode it again.


          Fix double encoding notebook path

4c23e5c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet