Merge pull request #1179 from fatfisz/fix-undefined-allow-multiline

Fix "allowMultiline" being undefined in some cases

Author: ljharb

lib/rules/jsx-curly-spacing.js

@@ -10,6 +10,8 @@
  */
 'use strict';
 
+var has = require('has');
+
 // ------------------------------------------------------------------------------
 // Rule Definition
 // ------------------------------------------------------------------------------
@@ -52,10 +54,13 @@ module.exports = {
 
   create: function(context) {
 
+    var DEFAULT_ALLOW_MULTILINE = true;
+
     var sourceCode = context.getSourceCode();
     var spaced = context.options[0] === SPACING.always;
-    var multiline = context.options[1] ? context.options[1].allowMultiline : true;
-    var spacing = context.options[1] ? context.options[1].spacing || {} : {};
+    var config = context.options[1] || {};
+    var multiline = has(config, 'allowMultiline') ? config.allowMultiline : DEFAULT_ALLOW_MULTILINE;
+    var spacing = config.spacing || {};
     var defaultSpacing = spaced ? SPACING.always : SPACING.never;
     var objectLiteralSpacing = spacing.objectLiterals || (spaced ? SPACING.always : SPACING.never);
 

tests/lib/rules/jsx-curly-spacing.js

@@ -86,6 +86,14 @@ ruleTester.run('jsx-curly-spacing', rule, {
     code: '<App foo={ bar } />;',
     options: ['always', {spacing: {}}],
     parserOptions: parserOptions
+  }, {
+    code: [
+      '<App foo={',
+      'bar',
+      '} />;'
+    ].join('\n'),
+    options: ['always', {spacing: {}}],
+    parserOptions: parserOptions
   }, {
     code: '<App foo={{ bar: true, baz: true }} />;',
     options: ['always', {spacing: {objectLiterals: 'never'}}],