Fix prop-types to not mark class static function as valid propTypes definition (fixes #1174)

Author: yannickcr

lib/rules/prop-types.js

@@ -879,7 +879,7 @@ module.exports = {
       },
 
       MethodDefinition: function(node) {
-        if (!isPropTypesDeclaration(node.key)) {
+        if (!node.static || node.kind !== 'get' || !isPropTypesDeclaration(node.key)) {
           return;
         }
 

tests/lib/rules/prop-types.js

@@ -2616,6 +2616,23 @@ ruleTester.run('prop-types', rule, {
       errors: [
         {message: '\'foo\' is missing in props validation'}
       ]
+    }, {
+      code: [
+        'class Hello extends React.Component {',
+        '  static propTypes() {',
+        '    return {',
+        '      name: PropTypes.string',
+        '    };',
+        '  }',
+        '  render() {',
+        '    return <div>Hello {this.props.name}</div>;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parserOptions: parserOptions,
+      errors: [
+        {message: '\'name\' is missing in props validation'}
+      ]
     }
   ]
 });

tests/lib/rules/require-default-props.js

@@ -1781,6 +1781,29 @@ ruleTester.run('require-default-props', rule, {
           column: 5
         }
       ]
+    },
+    {
+      code: [
+        'class Hello extends React.Component {',
+        '  static get propTypes() {',
+        '    return {',
+        '      name: PropTypes.string',
+        '    };',
+        '  }',
+        '  static defaultProps() {',
+        '    return {',
+        '      name: \'John\'',
+        '    };',
+        '  }',
+        '  render() {',
+        '    return <div>Hello {this.props.name}</div>;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint',
+      errors: [{
+        message: 'propType "name" is not required, but has no corresponding defaultProp declaration.'
+      }]
     }
   ]
 });