Skip to content

Introduced OTP code replay protection #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsuto wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −0
Open

Introduced OTP code replay protection #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions webui/controller/login/ga.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,24 @@ public function index(){

if(strlen($this->request->post['ga_code']) > 5 && $GA->verifyCode($settings['ga_secret'], $this->request->post['ga_code'], 2)) {

// RFC 6238 replay protection: reject previously used OTP codes
if(MEMCACHED_ENABLED) {
$memcache = Registry::get('memcache');
$cache_key = 'otp:' . $data['username'] . ':' . $this->request->post['ga_code'];

if($memcache->get($cache_key)) {
syslog(LOG_INFO, "GA auth rejected (OTP replay) for " . $data['username']);
$this->model_user_auth->increment_failed_login_count($this->data['failed_login_count']);
$this->data['failed_login_count']++;
$this->data['x'] = $this->data['text_invalid_pin_code'];
$this->render();
return;
}

// Store used OTP for 180 seconds (covers ±60s discrepancy window plus buffer)
$memcache->add($cache_key, '1', 180);
}

syslog(LOG_INFO, "GA auth successful for " . $data['username']);

$session->set("ga_block", "");
Expand Down