fomantic homepage #891
fomantic homepage #891
Conversation
BigBlueHat
commented
Dec 4, 2025
BigBlueHat
commented
- Move index.html to index.liquid.
- Overhaul homepage to use Fomantic-UI.
- Add Playground Next as a watch target.
- Fix Playground Next width to match homepage.
- Use Markdownn for Primer index.
- Use Markdown for Requirements index.
- Use Markdown for Specifications list.
- Move default.liquid to bs2.liquid.
- Add IDs to homepage sections and footer.
Also fix `active` class on Specifications dropdown (which caused the whole dropdown list to appear stuck open over the page...).
The `bs2.liquid` file is not currently used. Keeping it on hand in case some old page surfaces that we need to deal with.
BigBlueHat
requested review from
TallTed,
davidlehn,
iherman,
niklasl and
pchampin
davidlehn
left a comment
davidlehn
left a comment
There was a problem hiding this comment.
- For small screens the top menu needs "stackable" class or similar to be usable at all. Probably some collapsible thing too. Not sure how to make that work.
- Otherwise, looks good.
index.liquid
Outdated
| listed below is fully conforming to the official JSON-LD specifications. | ||
| </p> | ||
|
|
||
| <div class="ui four cards"> |
There was a problem hiding this comment.
This looks poor on mobile. Copying a hack from main section. Perhaps there's a better way.
| <div class="ui four cards"> | |
| <div class="ui four cards stackable grid"> |
There was a problem hiding this comment.
Good catch! I think we only need stackable though.
index.liquid
Outdated
| </p> | ||
| </div> | ||
|
|
||
| <div class="ui four cards"> |
There was a problem hiding this comment.
Same comment as in developer section.
| <div class="ui four cards"> | |
| <div class="ui four cards stackable grid"> |
_includes/implementation-card.liquid
Outdated
| <div class="header"><h3>{% if language %}{{ language | split: ',' | join: ' / ' }}{% else %}{{ applicationCategory }}{% endif %}</h3></div> | ||
| <div class="description"> | ||
| <div class="ui selection list"> | ||
| {% if language %} |
There was a problem hiding this comment.
Something in here is being too aggressive and including JavaScript entries in the Java section.
There was a problem hiding this comment.
Oh. I missed that. Ah... it's the contains bit. 😖 I'll see if I can improve that. Thanks!
There was a problem hiding this comment.
Here's the issue...contains is use for both array and string comparisons... 😖
You can use contains to check for the presence of a string within an array, or another string.
There was a problem hiding this comment.
@davidlehn k. That was painful...but it's fixed now. See: 6be40a2
|
I lack the expertise to review the code in details, but the results looks nice :) |
Liquid `contains` does (unfortunate...) double duty for both string and array matching and provides no way to create an array-only comparison based on exact equivalence. Consequently...this is the result.
Deploying json-ld-org with
|
| Latest commit: |
b117339
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://793e5525.json-ld-org.pages.dev |
| Branch Preview URL: | https://fomantic-homepage.json-ld-org.pages.dev |
davidlehn
left a comment
davidlehn
left a comment
There was a problem hiding this comment.
That implementation processing code is scary. It might be worth trying the preprocessing in js and hand something easier to handle to the template side.
